|
|
Hi Kerwin Memory issues are very sensitive right now. Please check if the code below causes memory leak. ( check the pResultBuf in the generateEdidXmlFile() function. ) platform-vendor-amlogic-common/frameworks/services/systemcontrol/HDCP# vi HDCPTxAuth.cpp =============================================================================================================== .. 68 static int saveFile(const char *path, char *buf, int bufLen) { 69 int fd, len = -1; 70 71 mode_t save_umask = umask(0133); 72 if ((fd = open(path, O_CREAT | O_RDWR | O_TRUNC, 0644)) < 0) { 73 SYS_LOGE("saveFile, open %s error(%s)", path, strerror(errno)); 74 umask(save_umask); 75 return len; 76 } 77 umask(save_umask); 78 79 len = write(fd, buf, bufLen); 80 close(fd); 81 return len; 82 } .. 246 void HDCPTxAuth::generateEdidXmlFile(void) 247 { 248 char* pResultBuf = NULL; 249 char tmpbuf[MAX_STR_LEN]={0}; 250 unsigned int resultSize=0; 251 unsigned int n=0; 252 unsigned int i=0; 253 const char *lineDelim = "\n"; 254 //EDID header 255 edidHeader_t edidHeader; 256 257 //Allocate a buffer to store xml 258 pResultBuf = (char*)malloc(MAX_EDID_FILE_SIZE); <==== Please check pResultBuf 259 if (!pResultBuf) { 260 SYS_LOGE("Fail to allocate buffer for generat EDID xml file"); 261 return; 262 } 263 memset(pResultBuf, 0, sizeof(pResultBuf)); .. 645 n = sprintf(pResultBuf+resultSize,"</supported_Color>\n</hdmi_edid>\n"); 646 if(n > 0) 647 resultSize += n; 648 else{ 649 SYS_LOGE("%s: sprintf fail\n",__FUNCTION__); 650 free(pResultBuf); 651 return; 652 } 653 saveFile(EDID_XML_FILE_PATH,pResultBuf,resultSize); <== Please check saveFile function and pResultBuf , there is no code to free pResultBuf 654 } .. ===================================================================================================================================== Thank you YK.Jung |
|
|
Hi YK, It is fixed and verified by dumpsys command. Patch is already committed to BitBucket. Thank you ! |
|
|
Hi kerwin, Please apply this patch to SWAN project. I think this issue will be same with SWAN. Thank you. |
|
|
Hi Mr. JunGyu Kim, The implementation is quite different on SWAN. Therefore, it can't be applied to SWAN. Thank you ~ |
|
|
Hi, Kerwin, SWAN used the edidinfo binary for generating the EDID xml file. And, there is generateEdidXmlFile function in vendor/foxconn/prebuilts/bin/edidinfo. To make clearly, could you please check the generateEdidXmlFile function in vendor/foxconn/prebuilts/bin/edidinfo? As you know already, the SWAN edidinfo author is Bcan. Thank you. |
|
|
Hi Sangmin, Please find the attached picture for SWAN implementation. Because SWAN uses a different implementation comparing to Eagle, we review the malloc() function in SWAN. Only one malloc() function is used as attached in the picture and is properly freed. SWAN_edidxml_malloc_review.jpg (48,083 bytes) |
|
|
Hi, River, Ok, Thank you. |
- yk.jung ( (ALTech) Younkwang Jung ) developer
